Repository navigation
Run the three abstract tests resolution 6 corrects beside the published ones - #84
Merged
Merged
Conversation
…ed ones Resolution 6 of the wiki page of Part 1 corrects three abstract tests of Annex A: A.20 validates the type against TemporalGeometrySequence and the member against geometrySequence, the schema its own Table A.7 cites; A.26 requests /velocity and A.27 /acceleration, the resources they are named for; and A.27 is run under the interpolations it names. ats_part1_corrected_test.go holds them as rows keyed by the identifier of the test each corrects, beside atsPart1, each naming the test that reads the answer it states, and checks that each corrects a test Annex A holds, that its request is routed and never to /distance, and that the test it names exists. The acceleration query resolves the geometry as the other queries do, reads its interpolation with interp, and states why that interpolation has no acceleration curve: Linear, Step, Discrete, and a single instant. interp joins the generated featureFunctions, so the catalog states it over 21 of the 23 temporal types and the query is refused for a collection of a type MobilityDB states no interp over; catalog_gen.go is regenerated from the catalog of MobilityDB master 843bec5d09. Witness. The query answered 501 before reading anything, so a Step or a Discrete geometry received the reason of a Linear one, and the acceleration of a collection, feature or geometry that does not exist answered 501 where every other query answers 404. Measured. go test passes; the corrected A.27 answers 501 with its own reason under each of Linear, Step, Discrete and None, 500 for a name MEOS does not carry, and 404 for the acceleration of a geometry the feature does not hold.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolution 6 of the wiki page of Part 1 corrects three abstract tests of
Annex A: A.20 validates the type against TemporalGeometrySequence and the
member against geometrySequence, the schema its own Table A.7 cites; A.26
requests /velocity and A.27 /acceleration, the resources they are named for;
and A.27 is run under the interpolations it names. ats_part1_corrected_test.go
holds them as rows keyed by the identifier of the test each corrects, beside
atsPart1, each naming the test that reads the answer it states, and checks
that each corrects a test Annex A holds, that its request is routed and never
to /distance, and that the test it names exists.
The acceleration query resolves the geometry as the other queries do, reads
its interpolation with interp, and states why that interpolation has no
acceleration curve: Linear, Step, Discrete, and a single instant. interp joins
the generated featureFunctions, so the catalog states it over 21 of the 23
temporal types and the query is refused for a collection of a type MobilityDB
states no interp over; catalog_gen.go is regenerated from the catalog of
MobilityDB master 843bec5d09.
Witness. The query answered 501 before reading anything, so a Step or a
Discrete geometry received the reason of a Linear one, and the acceleration of
a collection, feature or geometry that does not exist answered 501 where every
other query answers 404.
Measured. go test passes; the corrected A.27 answers 501 with its own reason
under each of Linear, Step, Discrete and None, 500 for a name MEOS does not
carry, and 404 for the acceleration of a geometry the feature does not hold.